Skip to content

Conversation

etpinard
Copy link
Contributor

glob and more importantly eslint have new major versions, this PR bumps the requirements.

@etpinard
Copy link
Contributor Author

@mdtusz eslint in version 2.0 cleaned up at lot of their spacing rules.

It might worthwhile to pick a style for the keyword-spacing rule together with space-before-blocks.

Personally (and I think @alexcjohnson would back me), I'd vote for:

 {
      "keyword-spacing": [2, {"overrides": {
          "if": {"beforer": false},
          "for": {"before": false},
          "while": {"before": false},
          "switch": {"before": false},
          "case": {"before": false}
      }}],
      "space-before-blocks": [2]
  }

so that

if(foo) {
    //...
}

for(var i = 0; i < N; i++) { 
  // ..
}

while(cond) {
  // ...
}

become standard.

@mdtusz
Copy link
Contributor

mdtusz commented Feb 15, 2016

I'm fine with anything, so long as it's consistent

I'm happy having linting for nearly everything.
💃

@etpinard
Copy link
Contributor Author

@mdtusz great. 🍻

I'll add the above rules and a few linting commits in a future PR, after the next release.

etpinard added a commit that referenced this pull request Feb 16, 2016
@etpinard etpinard merged commit 4221a2a into master Feb 16, 2016
@etpinard etpinard deleted the update-deps branch February 16, 2016 14:58
@etpinard etpinard mentioned this pull request Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants